fix(core): avoid portal-client import for enum conversions #850

matejchalk · 2024-10-16T15:05:05Z

Ran into error when @code-pushup/cli installed without @code-pushup/portal-client. There was a leftover static non-type import for converting CLI reports to portal. Came up with a type-safe way to not have to use the enum objects.

github-actions · 2024-10-16T15:11:12Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 937a322 with source commit f2744fd.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🟡 50	🟡 55
Code coverage	🟡 90	🟡 90
Custom checks	🟡 67	🟡 67	–
Security	🟡 82	🟡 82	–
Updates	🟡 75	🟡 75	–
Accessibility	🟢 91	🟢 91	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 61	🟡 61	–
Bug prevention	🟢 100	🟢 100	–
Code style	🟢 99	🟢 99	–

👍 2 groups improved, 👍 4 audits improved, 👎 2 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Lighthouse	Performance	🟡 50	🟡 55
Code coverage	Code coverage metrics	🟡 90	🟡 90

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	First Contentful Paint	🟥 3.1 s	🟨 2.7 s
Lighthouse	Largest Contentful Paint	🟨 3.3 s	🟨 2.8 s
Lighthouse	First Meaningful Paint	🟨 3.1 s	🟨 2.8 s
Lighthouse	Speed Index	🟥 7.0 s	🟥 7.3 s
Lighthouse	Time to Interactive	🟥 16.3 s	🟥 19.1 s
Code coverage	Function coverage	🟩 92.4 %	🟩 92.4 %
Lighthouse	Minimizes main-thread work	🟥 20.6 s	🟥 26.1 s
Lighthouse	Total Blocking Time	🟥 7,180 ms	🟥 12,230 ms
Lighthouse	JavaScript execution time	🟥 9.3 s	🟥 12.1 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Max Potential First Input Delay	🟥 2,500 ms	🟥 3,540 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 27 resources found	🟨 27 resources found
Lighthouse	Avoids enormous network payloads	🟩 Total size was 1,822 KiB	🟩 Total size was 1,822 KiB
Lighthouse	Eliminate render-blocking resources	🟥 Potential savings of 470 ms	🟥 Potential savings of 360 ms
Lighthouse	Server Backend Latencies	🟩 150 ms	🟩 90 ms
Lighthouse	Initial server response time was short	🟩 Root document took 530 ms	🟩 Root document took 480 ms
Lighthouse	Network Round Trip Times	🟩 80 ms	🟩 20 ms
Code coverage	Line coverage	🟩 90.7 %	🟩 90.7 %
Code coverage	Branch coverage	🟨 84.8 %	🟨 84.8 %